Walkthrough

The Member::addSponsorPermission() method was refactored to explicitly check for Sponsor_Users row existence using a locked SELECT query before executing an UPDATE. The return value now indicates row existence rather than relying on affected row counts. Two unit tests validate the updated behavior across different row lifecycle scenarios.

Changes

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~18 minutes

Possibly related PRs

• feat: per-sponsor member permission tracking with JSON column on Sponsor_User #523: Directly modifies the same Member::addSponsorPermission() method implementation, adjusting row-existence detection and return value semantics.

Suggested reviewers

• smarcet

Poem

🐰 Check before you hop, dear database friend,
SELECT FOR UPDATE, let locks defend!
Row exists or not, the return now rings true,
Idempotent updates—the right thing to do! ✨

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• X
• Mastodon
• Reddit
• LinkedIn